fix: Support sub-nanosecond precision on Cargo benchmarks#243
Closed
blaine-arcjet wants to merge 1 commit intobenchmark-action:masterfrom
Closed
fix: Support sub-nanosecond precision on Cargo benchmarks#243blaine-arcjet wants to merge 1 commit intobenchmark-action:masterfrom
blaine-arcjet wants to merge 1 commit intobenchmark-action:masterfrom
Conversation
Member
|
Thank you for this fix @blaine-arcjet. Could you please add a test case that fails without this? |
Contributor
Author
|
@ktrz I believe the "Rust Example" already in CI will fail if you run it because it pulls the latest nightly |
Member
|
I've added another test case to unit tests in #246 and found one more issue with parsing number as int instead of float. Now the full precision is stored in benchmarks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rust-lang/rust#124774, Rust changed the output of benchmarks to contain sub-nanosecond precision. This was first published in
nightly-2024-05-11which started breaking CI that used github-action-benchmark since it couldn't find any benchmarks in an output file.