This repository was archived by the owner on May 18, 2023. It is now read-only.
Fix race condition on 'now' when creating a timer#58
Merged
benbjohnson merged 1 commit intobenbjohnson:masterfrom May 18, 2023
Merged
Fix race condition on 'now' when creating a timer#58benbjohnson merged 1 commit intobenbjohnson:masterfrom
benbjohnson merged 1 commit intobenbjohnson:masterfrom
Conversation
djmitche
approved these changes
May 14, 2023
Collaborator
djmitche
left a comment
There was a problem hiding this comment.
This looks like a good fix. I thought I ran through this file and checked that all m.* access was done with m.mu held, but I guess I missed at least two places. If only the compiler could do this for us [cough]!
@benbjohnson I see you made a release recently. I don't use Go day-to-day anymore, so I'm no longer a user of this library. Would you like to resume maintenance of this library?
Owner
|
I'll go ahead and merge this and the other PR and cut a release. I haven't used this library for a long time so I'll probably archive it and someone can fork it if they're interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed solution to issue #57
The proposed solution is to capture
m.nowwithin the lock and use it subsequently after the lock is released. The added test case is somewhat fabricated in order to reproduce the issue initially usinggo test ./... -race -count=1.