Skip to content
This repository was archived by the owner on May 18, 2023. It is now read-only.

immediately fire a timer set to a negative duration#50

Merged
djmitche merged 1 commit intobenbjohnson:masterfrom
marten-seemann:immediately-fire-negative-timer
Apr 27, 2023
Merged

immediately fire a timer set to a negative duration#50
djmitche merged 1 commit intobenbjohnson:masterfrom
marten-seemann:immediately-fire-negative-timer

Conversation

@marten-seemann
Copy link
Copy Markdown
Contributor

Fixes #49.

@marten-seemann
Copy link
Copy Markdown
Contributor Author

@benbjohnson Friendly ping, would you mind reviewing this PR?

Copy link
Copy Markdown
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this compare to the behavior of the time package?

@marten-seemann
Copy link
Copy Markdown
Contributor Author

It's equivalent to what the time package does.

@djmitche
Copy link
Copy Markdown
Collaborator

Thanks!

@djmitche djmitche merged commit 4362d70 into benbjohnson:master Apr 27, 2023
@benbjohnson
Copy link
Copy Markdown
Owner

benbjohnson commented Apr 30, 2023

@marten-seemann Sorry for my slow response. Go ahead and merge as you see fit. No need to wait on me. 👍

@marten-seemann
Copy link
Copy Markdown
Contributor Author

@benbjohnson I don't think I have merge permissions in this repo.

@djmitche
Copy link
Copy Markdown
Collaborator

I already merged it :)

@marten-seemann
Copy link
Copy Markdown
Contributor Author

@benbjohnson Could we ask for a new release including this fix at some point please? 🙏

@benbjohnson
Copy link
Copy Markdown
Owner

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timer set to a negative duration doesn't fire until clock is advanced

3 participants