Fix(UI): correct dashboard URLs when mounted at root#44
Merged
igorbenav merged 2 commits intobenavlabs:mainfrom Jun 26, 2025
Merged
Fix(UI): correct dashboard URLs when mounted at root#44igorbenav merged 2 commits intobenavlabs:mainfrom
igorbenav merged 2 commits intobenavlabs:mainfrom
Conversation
Collaborator
|
Nice one, @andriialbatov! Just fix linting and I'll merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem
When mounting the admin panel at the root path (
mount_path="/"), dashboard content fails to load. The issue comes from templates building URLs like:With an empty
mount_path, this results in//dashboard-content, which doesn’t match any registered FastAPI route.✅ Solution
To fix this, I introduced a
url_prefixvariable in the Python context that normalizes the mount path with a leading slash only when necessary:All template links now use
{{ url_prefix }}instead of building paths manually:This ensures routes work whether the panel is mounted at
/,/admin, or any subpath.🧪 Testing
mount_path="/"→ dashboard loads ✅mount_path="/admin"→ still works as before ✅📹 Before Fix
Screen.Recording.2025-06-25.at.1.54.20.PM.mov