Simplify cache name snapshot creation#1955
Merged
ben-manes merged 3 commits intoMay 7, 2026
Merged
Conversation
|
Vinod Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
d0b53cf to
ac97a34
Compare
Contributor
Author
|
Thank you for the review and merge! Appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies
CacheManagerImpl#getCacheNames()by replacing the existingArrayList+Collections.unmodifiableCollection(...)usage withList.copyOf(...).Motivation
The current implementation creates a snapshot of the cache names and wraps it as an unmodifiable collection:
List.copyOf(...) provides the same intent more directly by creating an unmodifiable snapshot of the given collection.
Changes
This reduces boilerplate and improves readability without changing the method signature or intended behavior.
Notes
Collection<String>to preserve public binary compatibility.Validation
./gradlew :jcache:test./gradlew assemble