BH specs by qfox · Pull Request #167 · bem/bem-xjst

qfox · 2015-12-30T15:39:25Z

No description provided.

Fixes: bem#111

qfox · 2016-01-08T03:24:12Z

So, it's looks like almost done.

What's left:

Review specs
Restructure old tests
Decide to adapt/fix-in-major some issues in specs
Some else?

Anyway, at first we need your review folks.

cc @tadatuta @veged @arikon @indutny @vithar

indutny · 2016-01-08T04:36:46Z

May I ask you to write a bit of description of what's the purpose of this PR, what it is doing, and what things should like in the end?

qfox · 2016-01-09T12:51:20Z

@indutny The purpose of porting BH specs to find the difference between behaviour of BH and BEMHTML and to make structured specs in BEMHTML.

For now there are just 2 files with randomly written specs. The thing could be improved so we trying to do that.

arikon · 2016-01-09T20:32:51Z

cc @miripiruni

miripiruni · 2016-01-11T15:10:20Z

@arikon surely I'm watching all activity in bem-xjst and bh repos ;)

miripiruni · 2016-01-14T12:05:15Z

test/bh/applyNext-test.js

Этот тест был про bh.applyBase, и кажется, что эти тесты надо взять из текущих. Что нам вообще надо про applyNext?

IMHO Nope. We already have enough.

Well, there are no tests (as I see) for behaviour inside applyNext calls. So we need some.

miripiruni · 2016-01-14T13:08:56Z

test/bh/bem-test.js

It’s disputed issue...

miripiruni · 2016-01-14T16:37:21Z

So, the plan is:

Create issues if needed and fix it separately. Look at From BH tests label
Reorganize all test in structure.

miripiruni · 2016-01-27T00:32:13Z

Work in progress: 44e03ec

miripiruni · 2016-02-02T15:18:00Z

@zxqfox Can I close this PR by your favor? See #192

qfox · 2016-02-02T15:56:42Z

No, please! I wanna do it myself!

qfox added 3 commits December 30, 2015 18:36

bemhtml: fix elemMods behaviour

6f757c8

Fixes: bem#111

add tag tests

a667918

wip

5c0d00c

levonet added the status: review label Dec 30, 2015

tadatuta changed the title ~~BH specs~~ [WIP] BH specs Jan 1, 2016

qfox added 18 commits January 5, 2016 08:21

wip

cb385d4

wip

bce8d99

wip

0f13981

wip

eaba209

wip

19b1d21

wip

6289e97

wip

9ae8e4c

wip

7dc6898

wip

28e9b9b

wip

f0843bb

wip

27064be

wip

b5e7c56

wip

86daa06

wip

aeb6f47

wip

fb448d0

wip

3711736

chore: add sudo false for travis

74cc67a

wip

5e65482

miripiruni changed the title ~~[WIP] BH specs~~ BH specs Jan 13, 2016

miripiruni reviewed Jan 14, 2016
View reviewed changes

test/bh/bem-test.js

Copy link

Contributor

miripiruni Jan 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s disputed issue...

miripiruni mentioned this pull request Jan 21, 2016

BEMHTML: should properly render attr values #183

Merged

miripiruni self-assigned this Jan 26, 2016

qfox closed this Feb 2, 2016

levonet removed the status: review label Feb 2, 2016

qfox deleted the feature/bh-specs-porting branch February 2, 2016 15:57

miripiruni added scope: debuggability and removed scope: debuggability labels Mar 10, 2016

Conversation

qfox commented Dec 30, 2015

Uh oh!

qfox commented Jan 8, 2016

Uh oh!

indutny commented Jan 8, 2016

Uh oh!

qfox commented Jan 9, 2016

Uh oh!

arikon commented Jan 9, 2016

Uh oh!

miripiruni commented Jan 11, 2016

Uh oh!

miripiruni Jan 14, 2016

Choose a reason for hiding this comment

Uh oh!

qfox Jan 14, 2016

Choose a reason for hiding this comment

Uh oh!

miripiruni Jan 14, 2016

Choose a reason for hiding this comment

Uh oh!

qfox Jan 14, 2016

Choose a reason for hiding this comment

Uh oh!

miripiruni Jan 14, 2016

Choose a reason for hiding this comment

Uh oh!

miripiruni Jan 14, 2016

Choose a reason for hiding this comment

Uh oh!

miripiruni commented Jan 14, 2016

Uh oh!

miripiruni commented Jan 27, 2016

Uh oh!

miripiruni commented Feb 2, 2016

Uh oh!

qfox commented Feb 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants