Skip to content

bem-xjst 8.x support: js() to addJs()#2050

Merged
tadatuta merged 1 commit intov6from
bem-xjst-8x-support
Jun 2, 2017
Merged

bem-xjst 8.x support: js() to addJs()#2050
tadatuta merged 1 commit intov6from
bem-xjst-8x-support

Conversation

@miripiruni
Copy link
Contributor

@miripiruni miripiruni commented Jun 2, 2017

In addition to #2010
Closes #2049

@miripiruni miripiruni requested a review from tadatuta June 2, 2017 12:07
@miripiruni miripiruni force-pushed the bem-xjst-8x-support branch from ca38182 to 95c739d Compare June 2, 2017 12:50
Copy link
Member

@belozer belozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Есть вопрос

block('select').mod('mode', 'check')(
js()(function() {
addJs()(function() {
return this.extend(applyNext(), { text : this.ctx.text });
Copy link
Member

@belozer belozer Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miripiruni а здесь (и в других местах PR) не должно быть так?

addJs()(function() {
    return { text : this.ctx.text }
}),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@belozer абсолютно точно должно быть.

@miripiruni miripiruni force-pushed the bem-xjst-8x-support branch from 95c739d to 879df9c Compare June 2, 2017 13:24
@miripiruni
Copy link
Contributor Author

Updated

@tadatuta tadatuta changed the title bem-xjst 8.x support: js() to addJs() rewrived bem-xjst 8.x support: js() to addJs() Jun 2, 2017
@tadatuta tadatuta merged commit d600f24 into v6 Jun 2, 2017
@tadatuta tadatuta deleted the bem-xjst-8x-support branch June 2, 2017 14:25
@tadatuta tadatuta removed the ready label Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants