fix: fix fixture listing to use file_fixtures key presence#89
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 55.51% 55.48% -0.04%
==========================================
Files 26 26
Lines 3035 3035
==========================================
- Hits 1685 1684 -1
- Misses 1350 1351 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
69302a0 to
6eb11b5
Compare
There was a problem hiding this comment.
Pull request overview
This pull request fixes issue #88 where fixtures from editable installed packages were not appearing in the fixture list tree output. The root cause was that the code used path.is_file() to determine if a path contained fixtures, but for editable installs, paths are remapped to virtual site-packages locations that don't exist on disk, causing is_file() to return false.
Changes:
- Replace
path.is_file()checks withfile_fixtures.contains_key(path)in two locations to use data-driven checks instead of filesystem checks - Add comprehensive end-to-end tests for editable install fixture listing with three scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/fixtures/cli.rs | Replace path.is_file() with file_fixtures.contains_key(path) in print_tree_node and has_visible_fixtures functions to correctly identify virtual paths as fixture files |
| tests/test_e2e.rs | Add helper function and three comprehensive end-to-end tests to verify editable install fixtures appear correctly in tree output with different flag combinations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #88