fix: gate symlink test with #[cfg(unix)] to fix Windows clippy#86
Merged
bellini666 merged 1 commit intomasterfrom Feb 14, 2026
Merged
fix: gate symlink test with #[cfg(unix)] to fix Windows clippy#86bellini666 merged 1 commit intomasterfrom
bellini666 merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds path traversal protection to the pytest plugin entry point resolution logic and fixes a Windows clippy warning for a Unix-specific symlink test.
Changes:
- Added input validation to reject malicious module paths (path traversal attempts with "..", null bytes, or empty segments)
- Added canonicalization checks with boundary validation to prevent symlink-based escapes
- Updated existing test assertions to expect canonicalized paths
- Added comprehensive security tests for path traversal, null bytes, empty segments, and symlink escape attempts
- Properly gated the symlink escape test with
#[cfg(unix)]at the function level to fix Windows clippy errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
76f6146 to
541058a
Compare
541058a to
e6212b9
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 55.08% 55.08%
=======================================
Files 26 26
Lines 3001 3001
=======================================
Hits 1653 1653
Misses 1348 1348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[cfg(unix)]from the inner block to the test function level so that on Windows the entire test (including variable declarations) is excluded, fixing theunused variable: site_packagesclippy errorTest plan
cargo clippypasses locally