Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
=======================================
Coverage 61.25% 61.25%
=======================================
Files 26 26
Lines 3198 3198
=======================================
Hits 1959 1959
Misses 1239 1239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mohosy
reviewed
Feb 27, 2026
mohosy
left a comment
There was a problem hiding this comment.
Good targeted fix. The typo rename is applied consistently across resolver/types/provider/tests, and test expectations were updated, which reduces regression risk. Suggestion: because this enum variant is consumed in multiple modules, a quick changelog note about the symbol rename could help downstream contributors avoid stale references in local branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #95