Fix server crash when launched without console#1774
Merged
belav merged 2 commits intobelav:mainfrom Dec 13, 2025
Merged
Conversation
Remove Console.ReadKey() which throws InvalidOperationException when CSharpier server is started by IDE plugins (Rider, VS, VSCode) without a console attached. The call was unreachable during normal operation since RunAsync() blocks until shutdown.
belav
approved these changes
Dec 13, 2025
Owner
belav
left a comment
There was a problem hiding this comment.
Thanks for this. I wonder if this was the cause of csharpier server not working for some folks. I could never reproduce the issue locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Console.ReadKey()inServerFormatter.cswhich throwsInvalidOperationExceptionwhen CSharpier server is started by IDE plugins (Rider, VS, VSCode) without a console attachedRunAsync()blocks until shutdownProblem
When IDE plugins launch
csharpier server, the process crashes immediately with:This manifests in Rider as "Process exited unexpectedly" errors.