Skip to content

Fix condition causing FirstTargetFramework build property erasure#1696

Merged
belav merged 1 commit intobelav:mainfrom
tdg5:FirstTargetFrameworksFix
Sep 28, 2025
Merged

Fix condition causing FirstTargetFramework build property erasure#1696
belav merged 1 commit intobelav:mainfrom
tdg5:FirstTargetFrameworksFix

Conversation

@tdg5
Copy link
Copy Markdown
Contributor

@tdg5 tdg5 commented Sep 21, 2025

Many of my test projects fail to build when csharpier is added to them. They fail with this message:

Build FAILED.

"/Users/danny/src/tdg5/csharpier-build-issue-reproduction/App.Tests.csproj" (Rebuild target) (1:7) ->
"/Users/danny/src/tdg5/csharpier-build-issue-reproduction/App.Tests.csproj" (CSharpierFormatInner target) (1:8) ->
  /usr/local/share/dotnet/sdk/9.0.300/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(201,38):
    error MSB4184: The expression "[MSBuild]::VersionLessThan('', 6.0)" cannot be
    evaluated. Version string was not in a correct format.
    [/Users/danny/src/tdg5/csharpier-build-issue-reproduction/App.Tests.csproj]

For some reason, I only run into this problem with my test projects that include xunit.v3, but I'm fairly certain this is a csharpier issue.

A minimal reproduction of the issue can be found at tdg5/csharpier-build-issue-reproduction.

I believe the issue is that the FirstTargetFramework build property is getting clobbered due to a typo in a condition that's meant to check if FirstTargetFramework already has a value, but fails to do so because of the typo.

This PR fixes the typo and my build failures.

Let me know if I can answer any questions or provide any other context. Thanks!

@tdg5
Copy link
Copy Markdown
Contributor Author

tdg5 commented Sep 21, 2025

For anyone else running into this issue, a workaround can be to define both TargetFramework and TargetFrameworks. I believe most build tools are supposed to ignore TargetFrameworks if TargetFramework is defined, so hopefully other build tools would not be affected by the additional TargetFrameworks property. 🤞🏻

<TargetFramework>net9.0</TargetFramework>
<TargetFrameworks>$(TargetFramework)</TargetFrameworks>

@tdg5
Copy link
Copy Markdown
Contributor Author

tdg5 commented Sep 22, 2025

Another workaround for this problem that might come with less side effects is to set a value for FirstTargetFrameworks so the buggy condition is skipped (as it should be):

<TargetFramework>net9.0</TargetFramework>
<FirstTargetFrameworks>workaround-for-csharpier-pr-1696</FirstTargetFrameworks>

belav
belav approved these changes Sep 28, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@belav belav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to reproduce this but this is definitely a typo, and I don't know why things would be working with the typo there. Thanks for finding the fix!

@belav belav added this to the 1.2.0 milestone Sep 28, 2025
@belav belav merged commit 7069a14 into belav:main Sep 28, 2025
7 checks passed
@corngood
Copy link
Copy Markdown

corngood commented Feb 16, 2026

I hit this specifically when building on mac, because that particular version check only applies when the target is osx-arm64. I think that's probably why not everyone was able to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@belav belav belav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tdg5 @corngood @belav