In the following implementation, the ignore file is explicitly considered, when searching for a configuration file:
|
if (file.Exists && !ignoreFile.IsIgnored(file.FullName)) |
Does it really make sense to consider the ignore file, when searching for the configuration?
Wouldn't it be better to only consider the ignore file when determining files to format?
Environments:
- CSharpier Version: 1.0.0
- Running CSharpier via: dotnet cli
- Operating System: Debian
Steps to reproduce:
- Add the
.editorconfig to the .gitignore
- Apply the formatting
Expected behavior:
.gitignore should only be applied when determining files to format
.editorconfig is considered
Actual behavior:
.gitignore is also applied when looking for configuration files
.editorconfig is not considered at all
In the following implementation, the ignore file is explicitly considered, when searching for a configuration file:
csharpier/Src/CSharpier.Cli/EditorConfig/EditorConfigLocator.cs
Line 25 in 4b30a17
Does it really make sense to consider the ignore file, when searching for the configuration?
Wouldn't it be better to only consider the ignore file when determining files to format?
Environments:
Steps to reproduce:
.editorconfigto the.gitignoreExpected behavior:
.gitignoreshould only be applied when determining files to format.editorconfigis consideredActual behavior:
.gitignoreis also applied when looking for configuration files.editorconfigis not considered at all