Merged
Conversation
Member
|
Thanks - based on what I understand of Android 32-bit compiles, this makes sense, and it seems fairly innocuous; I'll leave it to @mhsmith for a final review and merge. |
mhsmith
requested changes
Apr 2, 2026
Member
There was a problem hiding this comment.
I'd prefer to do this in the zstd build script, in the same way as we already do for bzip2, for the following reasons:
- The android-env.sh should remain identical to the copy in the cpython repository.
- Many projects, including cpython itself, already add -fPIC to the command line, and having more than one copy of the argument makes it difficult to follow where it comes from.
- It's possible that the argument will at some point be necessary on other architectures.
4 tasks
Contributor
Author
|
Thanks, I will revise this. Preexisting projects that use the argument place it in a variety of different places and don't always restrict it only to 32-bit x86 or only to zstd, so I was just guessing where it should go. I will change it to the place you requested. |
-fPIC to builds for 32-bit x86 targetsCFLAGS for zstd
CFLAGS for zstd-fPIC to CFLAGS for zstd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-fPIC, causingerror: relocation R_386_PC32#8PR Checklist: