Add linuxdeploy plugins to initial project template.#30
Merged
Conversation
4 tasks
mhsmith
reviewed
Jul 20, 2022
Comment on lines
+42
to
48
| 'gir1.2-webkit-3.0', | ||
| 'libcairo2-dev', | ||
| 'libgirepository1.0-dev', | ||
| 'libgtk-3-dev', | ||
| 'libpango1.0-dev', | ||
| 'librsvg2-dev', | ||
| 'libwebkitgtk-3.0-0', |
Member
There was a problem hiding this comment.
According to the linuxdeploy-plugin-gtk README, some of these libraries are already installed by the plugin. I think anything handled by the plugin should be removed from system_requires, both to avoid confusion about where the libraries are coming from, and to simplify the pyproject file.
Member
There was a problem hiding this comment.
Sorry, disregard, I understand now. The plugin copies libraries from the build environment into the AppImage, but Briefcase is still responsible for making sure those libraries are installed in the build environment to begin with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In support of beeware/briefcase#756, this PR adds a
linuxdeploy_pluginsdeclaration to the new project template.PR Checklist: