Use a stub app as the flatpak bootstrap.#3
Merged
Merged
Conversation
4 tasks
mhsmith
reviewed
Jul 28, 2022
Comment on lines
+5
to
+7
| all: helloworld | ||
|
|
||
| helloworld: main.c |
Member
There was a problem hiding this comment.
This file should use template variables. When I use it in a project that isn't called "helloworld", I get this error:
...
Removing files/bin/pydoc3
Removing files/bin/idle3.8
Removing files/bin/idle3
Removing files/bin/2to3-3.8
Removing files/bin/2to3
Committing stage cleanup to cache
Finishing app
Error: Command 'testbed' not found
Building...
Error while building app testbed.
Member
Author
There was a problem hiding this comment.
whelp... that's embarrassing.
mhsmith
approved these changes
Jul 29, 2022
Member
|
This still hasn't been merged into the version-specific branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since building a Flatpak involves building everything from source anyway, this provides a convenient entry point to use a genuine stub app, rather than a shell script wrapping the Python interpreter.
This matches what is done with macOS and Windows apps. It provides complete control over the interpreter, and isolation from the environment in which the app runs.
Fixes beeware/briefcase#628
Refs beeware/briefcase#662
Addresses the flatpak edge case mentioned in beeware/briefcase#803.
This PR also enables dynamic linking, and strips unused parts of the bundle. This has the effect of reducing the size of a packaged HelloWorld Toga app from 42MB to 28MB.
PR Checklist: