Fixes #365 - Add notarisation for macOS apps#757
Merged
Conversation
Codecov Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds notarisation to the list of steps performed when packaging a macOS app.
This is effectively 2 system calls - one to submit the application for notarisation, and one to staple the result onto the packaged app.
Includes a small change to the content returned in debug output of subprocess calls - debug now includes the return value and console output. These were previously only included in deep debug.
Also improves the signing identity selection process, providing a command line hint for how to run without user interaction.
PR Checklist: