Add support for boundaryless regex#86
Conversation
|
So far, I have added a |
|
This is huge!!!!!!!!!!!!! |
|
forgot to say maybe, but this should integrate with filter system so you can filter say: only have boundaries on regex below 1.0 rarity etc :)) |
This one is already done. |
|
README left 😱 |
pywhat/what.py
Outdated
| @click.option( | ||
| "-br", | ||
| "--boundaryless-rarity", | ||
| help="Same as --rarity but for boundaryless.", |
There was a problem hiding this comment.
Why can't we just use --rarity for this? :)
There was a problem hiding this comment.
Because --rarity is used for filtration purposes and disables/enables regex fully, while --boundaryless-rarity disables/enables boundaryless mode
There was a problem hiding this comment.
Can we make that clear in the help menu somehow? :)
| "-be", "--boundaryless-exclude", help="Same as --exclude but for boundaryless." | ||
| ) | ||
| @click.option( | ||
| "-db", "--disable-boundaryless", is_flag=True, help="Disable boundaryless mode." |
There was a problem hiding this comment.
help="Disable boundaryless mode, allows you to search within strings"
There was a problem hiding this comment.
Umm, '-db' does not allow to search within strings🥲
There was a problem hiding this comment.
Disables boundaryless mode so inputs like jgakljgd127.0.0.1jfl will not match
There was a problem hiding this comment.
I have added an explanation of what boundaryless mode is to --help
| @click.option( | ||
| "-be", "--boundaryless-exclude", help="Same as --exclude but for boundaryless." | ||
| ) | ||
| @click.option( |
|
Breaking CLI changes btw |
|
API docs left🚀 |
|
Finally, API docs are updated |
|
Let me review and then merge :))) |
bee-san
left a comment
There was a problem hiding this comment.
Looks good other than my comments :)
| @click.option( | ||
| "-be", "--boundaryless-exclude", help="Same as --exclude but for boundaryless." | ||
| ) | ||
| @click.option( |
ToDo:
FilterclassFilterclassFilterclassre.search()