Skip to content

ci: disable testing python 3.6 on macos as it is no longer supported#237

Merged
2 commits merged intobee-san:mainfrom
jyooru:ci/macos-python36
Dec 2, 2021
Merged

ci: disable testing python 3.6 on macos as it is no longer supported#237
2 commits merged intobee-san:mainfrom
jyooru:ci/macos-python36

Conversation

@jyooru
Copy link
Copy Markdown
Contributor

@jyooru jyooru commented Dec 2, 2021

⚠ Pull Requests not made with this template will be automatically closed πŸ”₯

Prerequisites

Why do we need this pull request?

This repository has automatically switched to macos-11 from macos-10.15 as it has macos-latest specified.

This means that Python 3.6 is no longer available in GitHub Actions runners:

I had this commit on my fork as all actions would fail because of this issue. Looks like GitHub automatically updated my new fork to macos-11 but kept this repo on macos-10.15, but now this repo has been updated to macos-11.

What GitHub issues does this fix?

Copy / paste of output

Please copy and paste the output of PyWhat with your new addition using an example that tests this addition below:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #237 (539a172) into main (69da611) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          15       15           
  Lines        1217     1217           
=======================================
  Hits         1127     1127           
  Misses         90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 69da611...539a172. Read the comment docs.

@amadejpapez
Copy link
Copy Markdown
Collaborator

Updates and support for 3.6 seems to be ending at the end of the year, so that may be the reason. While we are at it could we add 3.10? :)

@jyooru
Copy link
Copy Markdown
Contributor Author

jyooru commented Dec 2, 2021

While we are at it could we add 3.10?

I added that in #221 πŸ˜„

@amadejpapez
Copy link
Copy Markdown
Collaborator

I added that in #221 πŸ˜„

Oh amazing thank you! I was looking at the test file in this PR where there is no 3.10. πŸ˜…

@bee-san
Copy link
Copy Markdown
Owner

bee-san commented Dec 2, 2021

We shall re-evaluate what Python version things use (Ubuntu, Remnux, etc etc) and see if we can up this limit in the new year :)

@bee-san bee-san enabled auto-merge December 2, 2021 10:15
@ghost ghost disabled auto-merge December 2, 2021 13:58
@ghost ghost merged commit cd9f020 into bee-san:main Dec 2, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI Checks fail

4 participants