perf: fix RegexIdentifier.check regression#218
Merged
bee-san merged 2 commits intobee-san:mainfrom Oct 22, 2021
Merged
Conversation
It looks like bee-san#167 has introduced a performance regression by adding what seems to be an unnecessary deep copy. A shallow dictionary copy seems to work just fine.
Codecov Report
@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 92.52% 92.51% -0.01%
==========================================
Files 14 14
Lines 1204 1203 -1
==========================================
- Hits 1114 1113 -1
Misses 90 90
Continue to review full report at Codecov.
|
ghost
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚠ Pull Requests not made with this template will be automatically closed 🔥
Prerequisites
Why do we need this pull request?
It looks like #167 has introduced a performance regression by adding what seems to be an unnecessary deep copy. A shallow dictionary copy seems to work just fine.
Profiling data collected with Austin shows the before/after difference when running
test_json_printing3Before
After
What GitHub issues does this fix?
A performance regression
Copy / paste of output