Remove duplicate regexes, add test to spot duplicate regexes#215
Merged
bee-san merged 2 commits intobee-san:mainfrom Oct 18, 2021
hexiro:Hexiro-patch-2
Merged
Remove duplicate regexes, add test to spot duplicate regexes#215bee-san merged 2 commits intobee-san:mainfrom hexiro:Hexiro-patch-2
bee-san merged 2 commits intobee-san:mainfrom
hexiro:Hexiro-patch-2
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 92.35% 92.37% +0.02%
==========================================
Files 14 14
Lines 1203 1207 +4
==========================================
+ Hits 1111 1115 +4
Misses 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bee-san
approved these changes
Oct 18, 2021
Owner
|
thanks so much!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Why do we need this pull request?
Adds a test to check for duplicate regexes by name. This is useful to prevent someone from adding a regex for something that already exists. Though, this might not always work out because the names need to be an exact match.
This also deletes one of the duplicate regexes.
What GitHub issues does this fix?
regex.json#213Copy / paste of output
Please copy and paste the output of PyWhat with your new addition using an example that tests this addition below:
Gets rid of second match