Skip to content

Add mount commands and fstab entries with clear credentials#210

Merged
bee-san merged 5 commits intobee-san:mainfrom
PabloLec:main
Oct 15, 2021
Merged

Add mount commands and fstab entries with clear credentials#210
bee-san merged 5 commits intobee-san:mainfrom
PabloLec:main

Conversation

@PabloLec
Copy link
Copy Markdown
Contributor

@PabloLec PabloLec commented Oct 12, 2021

Prerequisites

Why do we need this pull request?

  • Added support mount and mount.cifs commands with clear credentials as args. Can be found in various scripts. Complex commands with multiple arguments, flags and random arg order are supported.
  • Added similar support for fstab entries. Easily found vulnerability.
  • And fixed a typo in the test I wrote last evening 🤒

Copy / paste of output

❯ pywhat "mount -o username=myuser,password=password"
Matched on: mount -o username=myuser,password=password
Name: Mount Command With Clear Credentials
❯ pywhat "cifs uid=1000,password=password,gid=1000,noperm,nofail,username=myuser"
Matched on: cifs uid=1000,password=password,gid=1000,noperm,nofail,username=myuser
Name: CIFS Fstab Entry With Clear Credentials

ghost
ghost reviewed Oct 12, 2021
View reviewed changes
pywhat/Data/regex.json Outdated
},
{
"Name": "Mount Command With Clear Credentials",
"Regex": "^(mount(.cifs)?[ ]+[^\\n]*(username=[^, \\n]+[^\\n ]*password=[^, \\n]+|password=[^, \\n]+[^\\n ]*username=[^, \\n]+))$",
Copy link
Copy Markdown

@ghost ghost Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What[ ]+ is supposed to mean? Why not \s+?

Copy link
Copy Markdown
Contributor Author

@PabloLec PabloLec Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ ]+ indeed does have the same meaning as \s+, I'll change it if it's more meaningful.

@PabloLec
Copy link
Copy Markdown
Contributor Author

PabloLec commented Oct 12, 2021

Code seems to break with the change, let me check out why.

@PabloLec
Copy link
Copy Markdown
Contributor Author

PabloLec commented Oct 12, 2021 •
edited
Loading

FIxed 😉

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 13, 2021 •
edited
Loading

Codecov Report

Merging #210 (74c386a) into main (e8aaaaa) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   94.46%   94.50%   +0.03%     
==========================================
  Files          14       14              
  Lines        1717     1729      +12     
==========================================
+ Hits         1622     1634      +12     
  Misses         95       95
Impacted Files Coverage Δ
tests/test_regex_formatting.py 100.00% <ø> (ø)
tests/test_regex_identifier.py 98.57% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8aaaaa...74c386a. Read the comment docs.

@PabloLec
Copy link
Copy Markdown
Contributor Author

PabloLec commented Oct 13, 2021

Windows tests failure are currently investigated by GitHub > https://www.githubstatus.com/

@PabloLec
Copy link
Copy Markdown
Contributor Author

PabloLec commented Oct 15, 2021

Tests should now be able to run normally by the way 😉

@bee-san bee-san merged commit 2589780 into bee-san:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bee-san bee-san bee-san approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PabloLec @codecov-commenter @bee-san