Skip to content

Improve printing#207

Merged
5 commits merged intomainfrom
improve-printing
Oct 12, 2021
Merged

Improve printing#207
5 commits merged intomainfrom
improve-printing

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 11, 2021

⚠ Pull Requests not made with this template will be automatically closed 🔥

Prerequisites

Why do we need this pull request?

Currently, pywhat does not print tags and it's output cannot be customized.

What GitHub issues does this fix?

Copy / paste of output

Please copy and paste the output of PyWhat with your new addition using an example that tests this addition below:

$ pywhat --format '%n - %m' user@mail.com
Uniform Resource Locator (URL) - mail.com
Email Address - user@mail.com

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 11, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 98.09524% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.46%. Comparing base (8b1c605) to head (295d59b).
⚠️ Report is 109 commits behind head on main.

Files with missing lines Patch % Lines
pywhat/printer.py 94.73% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   92.27%   94.46%   +2.19%     
==========================================
  Files          14       14              
  Lines        1644     1717      +73     
==========================================
+ Hits         1517     1622     +105     
+ Misses        127       95      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ghost ghost merged commit e8aaaaa into main Oct 12, 2021
@ghost ghost deleted the improve-printing branch October 12, 2021 20:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI should print rarity and tags of entry

3 participants