Merged
Conversation
…tly regex and added test for it, fixed test function and used it
bee-san
reviewed
Oct 6, 2021
Owner
bee-san
left a comment
There was a problem hiding this comment.
Some great work here 👏👏👏👏 Thank you!!! 💖💖💖
ghost
reviewed
Oct 6, 2021
bee-san
reviewed
Oct 6, 2021
Refactored `_assert_match_in_items` Co-authored-by: Bee <github@skerritt.blog>
bee-san
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Again 👋
_assert_match_first_itembecause Visual Studio Token and Bitly now has the same regex, and i noticed that there was an unused function called_assert_match_in_itemsso i rewrote it and used it for both of themand if you want to me to refactor the tests so that all of them uses either
_assert_match_in_itemsand_assert_match_first_itemonly i can do it