added nano; simplify#168
Conversation
pywhat/Data/regex.json
Outdated
| "Regex": "^(nano|xrb)_[13]{1}[13456789abcdefghijkmnopqrstuwxyz]{59}$", | ||
| "plural_name": false, | ||
| "Description": null, | ||
| "Rarity": 0.8, |
There was a problem hiding this comment.
This is probably 1 because it require having the string nano or xrb in it :)
There was a problem hiding this comment.
i thought so too but I didn't want to over estimate. I can make that change today. What about the 10 checks failing?
There was a problem hiding this comment.
Try running pytest on your machine inside of the PyWhat directory, so that tests run and you can see the reason why ones are failing.
And don't forget to run black and isort for your code formatting. :)
|
Failing because: |
gotcha gotcha that makes sense. Will change when i get the chance :) |
|
I'll check this out later when I'm on my home pc and make sure there are no more failing tests. |
|
does the position in |
thanks to SkeletalDemise and r49behind from bee's discord :)
|
Hey! Mind fixing the merge conflict and I can merge? Thanks!!! :) |
|
merge conflicts gone 🦀 |
made some small changes which shouldn't affect logic and added nano.
changes:
scripts/get_file_sigs.pyuse https protocoldict()with{}if / elsesw/ ternary expressionsset([])w/{}lmk what you think 👍🏼