Skip to content

Automatically fill in the Curl webhook#157

Merged
4 commits merged intobee-san:mainfrom
colinodell:add-match-to-curl
Oct 2, 2021
Merged

Automatically fill in the Curl webhook#157
4 commits merged intobee-san:mainfrom
colinodell:add-match-to-curl

Conversation

@colinodell
Copy link
Copy Markdown
Contributor

@colinodell colinodell commented Oct 2, 2021

Implements #152

Not the prettiest solution but it seems to work fine, so long as the exploit uses a placeholder that's in all-caps and ends with _HERE.

@colinodell colinodell changed the title Automatically fill in the Curl webhook (implements #152) Automatically fill in the Curl webhook Oct 2, 2021
@ghost
Copy link
Copy Markdown

ghost commented Oct 2, 2021

This feature should be implemented on the API level, so all calls to Identifier.identify() return formatted exploit. Check regex_identifier.py.

@ghost
Copy link
Copy Markdown

ghost commented Oct 2, 2021

Failing tests😢

@colinodell
Copy link
Copy Markdown
Contributor Author

Yep, that's what I get for not running the test suite locally before pushing 🤦 should be fixed now!

I also noticed that the Slack exploits included a redundant xoxp- prefix immediately before the TOKEN_HERE, so I removed that and added a missing test.

@ghost ghost enabled auto-merge October 2, 2021 15:39
@ghost
Copy link
Copy Markdown

ghost commented Oct 2, 2021

That is amazing! Thank you a lot @colinodell 😀

@ghost ghost linked an issue Oct 2, 2021 that may be closed by this pull request
@ghost ghost merged commit 2bf89ba into bee-san:main Oct 2, 2021
@colinodell colinodell deleted the add-match-to-curl branch October 2, 2021 16:09
@bee-san
Copy link
Copy Markdown
Owner

bee-san commented Oct 3, 2021

Thanks for thiis! <3

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically fill in the Curl webhook

3 participants