Merged
Conversation
ghost
approved these changes
Aug 26, 2021
SkeletalDemise
approved these changes
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--jsoncommand option did not work for URLs, emails,... The reason was that forward slash in regex has to escaped with two backslashes. Otherwise it can cause issues with json in some cases. Some regexes already had it this way, but most used just one backslash. (fixes Exception when using --json with email input #126)fixtures/filewith--jsonoption, so we can hopefully catch any future issuesI also noticed that
--jsondid not work for MAC addresses and other regexes with "children", because "children" are using Python Sets andjsondoes not work with that type, but this is fixed by #134 as it removes "children" from being printed with the results. :)