Make searching filenames for matches optional#128
Merged
amadejpapez merged 3 commits intomainfrom Aug 10, 2021
Merged
Conversation
ghost
suggested changes
Aug 7, 2021
ghost
left a comment
There was a problem hiding this comment.
API docs should be updated after this gets merged.
bee-san
requested changes
Aug 7, 2021
ghost
approved these changes
Aug 7, 2021
bee-san
reviewed
Aug 8, 2021
| ) | ||
| @click.option("-i", "--include", help="Only show matches with these tags.") | ||
| @click.option("-e", "--exclude", help="Disclude matches with these tags.") | ||
| @click.option("-e", "--exclude", help="Exclude matches with these tags.") |
bee-san
approved these changes
Aug 8, 2021
Owner
|
@amadejpapez you can merge if you want!! normally in industry β¨ when ew approve something, its up to you to merge it as you may want to add some things last minute etc :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously PyWhat always added the name of the file to the search. This PR makes it optional, so if someone wants PyWhat to also search filenames for any matches, they can now do it with
-ifcommand.