Skip to content

Make searching filenames for matches optional#128

Merged
amadejpapez merged 3 commits intomainfrom
search-filenames
Aug 10, 2021
Merged

Make searching filenames for matches optional#128
amadejpapez merged 3 commits intomainfrom
search-filenames

Conversation

@amadejpapez
Copy link
Copy Markdown
Collaborator

@amadejpapez amadejpapez commented Aug 6, 2021

Previously PyWhat always added the name of the file to the search. This PR makes it optional, so if someone wants PyWhat to also search filenames for any matches, they can now do it with -if command.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API docs should be updated after this gets merged.

)
@click.option("-i", "--include", help="Only show matches with these tags.")
@click.option("-e", "--exclude", help="Disclude matches with these tags.")
@click.option("-e", "--exclude", help="Exclude matches with these tags.")
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICEE!!!!!

@bee-san
Copy link
Copy Markdown
Owner

bee-san commented Aug 10, 2021

@amadejpapez you can merge if you want!! normally in industry ✨ when ew approve something, its up to you to merge it as you may want to add some things last minute etc :)

@amadejpapez amadejpapez merged commit da59c98 into main Aug 10, 2021
@amadejpapez amadejpapez deleted the search-filenames branch August 10, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants