You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not quite sure whats happening: with the hardcoded boundaries ^((?:[/dp/]|$)([A-Z0-9]{10}))$, the tests fail and without them (?:[/dp/]|$)([A-Z0-9]{10}) they pass. I'm looking into it more, but if you have any quick insights, I'd appreciate the feedback.
Your regex is matching to only /dp/B0015T963C, so it doesn't match as there is something before it. If you add only this part as a test it will pass. 😄
Your regex is matching to only /dp/B0015T963C, so it doesn't match as there is something before it. If you add only this part as a test it will pass. smile
Oh, I see! I had lost sight of main use of pyWhat while using regex101 and was extracting ASINs from strings instead of checking if a string is an ASIN. Updating now with new regex removing URL specific aspects.
This is happening because with hardcoded boundaries the whole match needs to be in one line with nothing else around it. http://www.amazon.com/Kindle-Wireless-Reading-Display-Generation/dp/B0015T963C
Your regex is matching to only /dp/B0015T963C, so it doesn't match as there is something before it. If you add only this part as a test it will pass. smile
Oh, I see! I had lost sight of main use of pyWhat while using regex101 and was extracting ASINs from strings instead of checking if a string is an ASIN. Updating now with new regex removing URL specific aspects.
I think in bounardyless mode we do extract that string, but we need it to have boundaries in our database so we can take them away in our boundaryless mode :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.