BugFix: Allow IPV6 addresses to be parsed into NMAP #620
Conversation
|
Here is the prof that the fix works by providing the IP version 
|
|
@israelrg, this is nice. In principle I agree with the change but instead of relying on a failed At the moment it looks like the Also, probably worth adding a test or two in this module to validate the behaviour. |
|
Hi @PsypherPunk, |
|
@israelrg, yep: that looks good. The only outstanding comment would be to extend the tests to validate the change. |
PsypherPunk
left a comment
There was a problem hiding this comment.
I'm happy to accept this: although I think adding tests would be useful, I don't think our code is currently structured in a way to easily do that (other than manually, which I have).
Hi,
My ISP defaults to IPV6. I found that the IPV6 version of the domain www.google.es can't be scanned. I attached you a prof one with the domain name translated into IPV6 and the other with the IPV4 address that nslookup resolves.
This is what I'm referring to
Open [2a00:1450:4003:80f::2003]:443 [~] Starting Script(s) 2a00:1450:4003:80f::2003 looks like an IPv6 target specification -- you have to use the -6 option.I added support to IPV6 by providing the version, both 4 & 6
Regards 🙂