Conversation
* Descriptions only appear if the regex has it. We only have 2 regex with descriptions. * Descriptions with links are embedded as hyperlinks, this doesn't work on CMD but tbh microsoft is slowly moving to Windows Terminal and who really cares if the link works. * Descriptions are "naturalised" so they have a lowercase first letter and end with a full stop. * Regex with URLs are shown too, they use both Rich hyperlinking and just printing the URL. These regex are rare. The idea is that if someone comes across lat / long coords, their next stop is Google Maps. We can take them directly there, eliminating the middleman and improving user experience. Unforunately due to iface I can only show links at the checkers returned level, not near the plaintext :-(
Owner
Author
|
#650 solves the issues raised in the body of the PR, should be okay now 👍🏻 |
Owner
Author
|
^^ Test greppable mode for this btw |
Owner
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These regex are rare. The idea is that if someone comes across lat / long coords, their next stop is Google Maps. We can take them directly there, eliminating the middleman and improving user experience.
Unfortunately due to iface I can only show links at the checkers returned level, not near the plaintext :-(]
Note: In the next version of
pywhatthe wikipedia link is turned into a hyperlink, so it's not as ugly.PS: I don't know why the 2nd link isn't coming up as blue, but when we move to hyperlinks in bee-san/pyWhat#32 it should be okay :-)