Skip to content

Support Python 3.9 (Fix #558)#586

Merged
SkeletalDemise merged 4 commits intobee-san:masterfrom
JesseEmond:fix-python-3.9
Feb 28, 2021
Merged

Support Python 3.9 (Fix #558)#586
SkeletalDemise merged 4 commits intobee-san:masterfrom
JesseEmond:fix-python-3.9

Conversation

@JesseEmond
Copy link
Copy Markdown

This issue was already raised on https://bugs.python.org/issue36517,
adding a TODO to consider going back to Generic[T] once this is solved.

Tested python -m ciphey -t "aGVsbG8gbXkgbmFtZSBpcyBiZWU=" on Python 3.9, and it works with this fix.

This issue was already raised on https://bugs.python.org/issue36517,
adding a TODO to consider going back to Generic[T] once this is solved.
@JesseEmond
Copy link
Copy Markdown
Author

Should I include a change to https://github.com/Ciphey/Ciphey/blob/master/.github/workflows/terminaltest.yml#L10 to include 3.9 as part of this PR?

@bee-san
Copy link
Copy Markdown
Owner

bee-san commented Feb 28, 2021

Hey @JesseEmond

Thanks for this <3

Do you mind editing our tests to include pythobn 3.9?

https://github.com/Ciphey/Ciphey/blob/master/.github/workflows/tests2.yml

^ I think that's what we use for CI, but the name is quite bad haha

@bee-san
Copy link
Copy Markdown
Owner

bee-san commented Feb 28, 2021

Hey!

This fails on Windows, which is okay -- it's not your fault.

We're removing CipheyCore so Windows will work in the future. For now, Linux & Mac OS support on 3.9 is great 🥳

I think we're going to take this & intentionally fail our CI until we can add support for Windows when we remove CipheyCore.

Thanks so much!

@all-contributors please add @JesseEmond for code

@allcontributors
Copy link
Copy Markdown
Contributor

@bee-san

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@SkeletalDemise SkeletalDemise merged commit 19ef456 into bee-san:master Feb 28, 2021
@SkeletalDemise
Copy link
Copy Markdown
Contributor

@all-contributors please add @JesseEmond for code

@allcontributors
Copy link
Copy Markdown
Contributor

@SkeletalDemise

I've put up a pull request to add @JesseEmond! 🎉

@bee-san
Copy link
Copy Markdown
Owner

bee-san commented May 20, 2021

Hey we're changing from MIT to GPLv3 because some of our projects are licensed with that, do you approve? If you do not approve we will be forced to delete your code and rewrite it 😢

By approving of this change, you are agreeing to re-license the code you wrote under GPLv3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants