Merged
Conversation
Cyclic3
suggested changes
Oct 22, 2020
Contributor
Cyclic3
left a comment
There was a problem hiding this comment.
May I suggest "methods" or "systems" instead of "encryptions"?
SkeletalDemise
approved these changes
Oct 23, 2020
Contributor
|
I'm merging this because I think it's more clear now. I changed the wording of it to include encodings too and added some more examples. In my opinion, "methods" or "systems" are both too vague. Also, classical ciphers like the Vigenere cipher or the Affine cipher are encryptions and it's not incorrect to call them that. |
Cyclic3
approved these changes
Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're no longer 30+ things, we're now 50+ things (in 1 new decoder or whatever) 😄