Conversation
|
Haven’t tested it yet, but good job with the comments! Makes maintaining so much easier. Thank you! |
|
Can you make this a draft please? :) I'll check it out in a second |
|
@Mr-Salme thanks! Code is meant to be read : ) |
|
Make sure to resolve conflicts too when you make this not-a-draft :) |
|
Is this PR ready? @SkeletalDemise anything you want to do? |
|
Personally I think it is ready, but I'd prefer if some took a real close look at it - seeing that this is my first PR : ) |
|
@all-contributors please add @Ozzyz for code |
|
I've put up a pull request to add @Ozzyz! 🎉 |
|
Hey we're changing from MIT to GPLv3 because some of our projects are licensed with that, do you approve? If you do not approve we will be forced to delete your code and rewrite it 😢 By approving of this change, you are agreeing to re-license the code you wrote under GPLv3. |
|
@bee-san I approve |
Fixes #346
Heya 👋
This is my first PR to Ciphey, so please add as much input/feedback as possible!
The test case is functioning on my end
About the Cracker
This cracks the affine cipher, which has two keys, namely a, and b. The Caesar Cipher is a special version of the affine cipher with a=1 and b=the shift.
This verison of the affine cracker is written in Python, as the number of possible keys are very small. For an alfabet of length 26, there are 312 keys (since a has to be coprime to 26).
TODO:
There remain some minor cleanup, but I am writing this PR now so that you have time to give some feedback while I fix these small issues.
Things I am aware of that needs fixing:
Questions:
Looking forward to your feedback :)