Skip to content

Add Braille (Grade 1)#462

Merged
SkeletalDemise merged 5 commits intobee-san:masterfrom
rogercyyu:braille-issue-439
Nov 24, 2020
Merged

Add Braille (Grade 1)#462
SkeletalDemise merged 5 commits intobee-san:masterfrom
rogercyyu:braille-issue-439

Conversation

@rogercyyu
Copy link
Copy Markdown
Contributor

Hello, I added Braille grade 1 feature for issue-439.
Not sure how to do grade 2 aka contractions.

Not sure if I covered everything for grade 1...

Looking for feedback.

bee-san
bee-san previously requested changes Oct 1, 2020
@bee-san bee-san requested a review from SkeletalDemise October 1, 2020 23:55
@bee-san
Copy link
Copy Markdown
Owner

bee-san commented Oct 1, 2020

Requesting code review from @SkeletalDemise as they know far more about this kind of stuff than I do :P

@rogercyyu
Copy link
Copy Markdown
Contributor Author

Hey so, I am gonna let @Trisanu-007 worked on these issue on my branch for a bit (till Oct 8th), if that is okay with the team? Or can GitHub allow 2 people on a PR?

@bee-san
Copy link
Copy Markdown
Owner

bee-san commented Oct 2, 2020

Hey so, I am gonna let @Trisanu-007 worked on these issue on my branch for a bit (till Oct 8th), if that is okay with the team? Or can GitHub allow 2 people on a PR?

Hey! I can mark one of you as a co-author :)

@rogercyyu
Copy link
Copy Markdown
Contributor Author

That would be awesome! Thank-you! :D

@bee-san
Copy link
Copy Markdown
Owner

bee-san commented Oct 6, 2020

@bee-san
Copy link
Copy Markdown
Owner

bee-san commented Oct 10, 2020

Hey, you need to add the alphabet to cipheydists :)

@rogercyyu
Copy link
Copy Markdown
Contributor Author

Hey, slowly working on it... I'll send a PR to cipheydists when I feel I got most of the symbols ready :P

@rogercyyu rogercyyu force-pushed the braille-issue-439 branch 3 times, most recently from 6f4461c to 0cec0a3 Compare November 8, 2020 03:43
@rogercyyu rogercyyu closed this Nov 8, 2020
@rogercyyu rogercyyu reopened this Nov 8, 2020
* fixed bugs

* fixed bug with comma
@SkeletalDemise SkeletalDemise linked an issue Nov 24, 2020 that may be closed by this pull request
@SkeletalDemise
Copy link
Copy Markdown
Contributor

@all-contributors please add @rogercyyu for code

@allcontributors
Copy link
Copy Markdown
Contributor

@SkeletalDemise

I've put up a pull request to add @rogercyyu! 🎉

@SkeletalDemise SkeletalDemise dismissed bee-san’s stale review November 24, 2020 08:28

The change requested is done

@SkeletalDemise SkeletalDemise merged commit 7b2469a into bee-san:master Nov 24, 2020
@bee-san
Copy link
Copy Markdown
Owner

bee-san commented May 20, 2021

Hey we're changing from MIT to GPLv3 because some of our projects are licensed with that, do you approve? If you do not approve we will be forced to delete your code and rewrite it 😢

By approving of this change, you are agreeing to re-license the code you wrote under GPLv3.

@rogercyyu
Copy link
Copy Markdown
Contributor Author

@bee-san I approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Braille Decoder

4 participants