Add arm64 binary support for Linux and macOS#112
Merged
Conversation
Co-authored-by: becheran <22472855+becheran@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for arm64 binaries in mlc
Add arm64 binary support for Linux and macOS
Dec 6, 2025
becheran
approved these changes
Dec 8, 2025
Owner
|
@copilot fix the failing linux arm64 build |
Co-authored-by: becheran <22472855+becheran@users.noreply.github.com>
Contributor
Author
Fixed the linux arm64 build in commit 50df981. The issue was that we were using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Fix failing linux arm64 build
Issue Summary
The linux arm64 build was failing because we were using
aarch64-linux-gnu-gcc(glibc toolchain) as the linker foraarch64-unknown-linux-musl(musl target), causing undefined reference errors for glibc-specific fortified functions like__memcpy_chk.Fix
Switched to using
cross(cross-rs) which properly handles cross-compilation for ARM64 musl targets using Docker containers with the correct toolchain.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.