Improve performance of Assertion Chain class#318
Merged
beberlei merged 1 commit intobeberlei:masterfrom Dec 16, 2021
Merged
Conversation
Contributor
Author
|
@beberlei - is there any change to take a look at this changes, please? :) |
Owner
|
@scyzoryck thank you very much! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
During testing performance of the package with PHPBench I've realised that Reflections methods and checking if method exists takes a lot of time. With the simple fixes we can cut execution time by around 10-15% for lazy assertions.
Benchmark can be found here: scyzoryck/php-validators-benchmark
I'm attaching blackfire profiles: