Merged
Conversation
…ion for use with Assertion::count(), Assertion::isCountable(), Assertion::minCount(), and Assertion::maxCount() to operate on ResourceBundles.
Sincerely apologies to the BC break.
Fixes beberlei#288. While beberlei#268 and beberlei#269 updated count() and isCountable() to now work with intl resources, beberlei#286 made that the whole beberlei/assert package now requires the intl extension to be installed. However, the intl extension dependency is a soft dependency. The package does not need intl for most of its features and can safely work without it.
### Fixes - Reinstated the `@method` return type for `Assert\LazyAssertion` methods to show that the return type is `LazyAssertion`.
This was referenced Dec 21, 2020
|
Hello, any news about merging this PR, please? May I help somehow? :) |
Contributor
Author
|
Any news here? |
thirsch
reviewed
Apr 16, 2021
Owner
|
@wilsonge thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309
I've done my best to resolve conflicts. But hopefully the unit tests will point out if I've missed anything along the way hopefully!
Also once this is merged can you guys update the changelog for version 3.3.0 then release 3.3.1 :)