Skip to content

Conversation

@carlosms
Copy link
Collaborator

@carlosms carlosms commented Mar 8, 2019

Fix #158.

a

@smacker
Copy link
Collaborator

smacker commented Mar 8, 2019

CI is failing

const languageVersions = Object.keys(languages).reduce((acc, k) => {
const { version, name } = languages[k];

if (version === undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this happens?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the (auto) language is found. I changed this to make it more clear in 8d31e67.

@carlosms carlosms force-pushed the driver-versions branch 2 times, most recently from 684deeb to 8d31e67 Compare March 8, 2019 16:01
carlosms added 2 commits March 8, 2019 16:18
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
@carlosms carlosms merged commit d0df114 into bblfsh:master Mar 12, 2019
@carlosms carlosms deleted the driver-versions branch March 12, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants