Skip to content

Use log wrapper instead of console.error directly #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smacker merged 1 commit into from
Jan 10, 2018
Merged

Use log wrapper instead of console.error directly #112

smacker merged 1 commit into from
Jan 10, 2018

Conversation

@smacker
Copy link
Collaborator

@smacker smacker commented Jan 9, 2018

Fixes: #86

@smacker smacker requested a review from dpordomingo January 9, 2018 14:41
@smacker
Use log wrapper instead of console.error directly
60a5f15 
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
dpordomingo
dpordomingo approved these changes Jan 10, 2018
View reviewed changes
Copy link
Member

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, you can merge

@smacker smacker merged commit d196095 into bblfsh:master Jan 10, 2018
@dpordomingo dpordomingo mentioned this pull request Mar 28, 2018
Merged
This was referenced Jan 9, 2019
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpordomingo dpordomingo dpordomingo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smacker @dpordomingo