Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Use version range for grpcio instead of exact version#138

Merged
juanjux merged 1 commit intobblfsh:masterfrom
smacker:use_version_range_for_grpcio
Dec 11, 2018
Merged

Use version range for grpcio instead of exact version#138
juanjux merged 1 commit intobblfsh:masterfrom
smacker:use_version_range_for_grpcio

Conversation

@smacker
Copy link
Copy Markdown
Contributor

@smacker smacker commented Dec 7, 2018

Fixed version of grpcio is causing error when an application needs to use
newer compatible grpcio:
bblfsh 2.11.2 has requirement grpcio==1.13.0, but you'll have grpcio 1.17.0
which is incompatible.

In my case I stumbled on this bug that is fixed in newer grpcio:
grpc/grpc#14088

Signed-off-by: Maxim Sukharev max@smacker.ru

Fixed version of grpcio is causing error when an application needs to use
newer compatible grpcio:
bblfsh 2.11.2 has requirement grpcio==1.13.0, but you'll have grpcio 1.17.0
which is incompatible.

In my case I stumbled on this bug that is fixed in newer grpcio:
grpc/grpc#14088

Signed-off-by: Maxim Sukharev <max@smacker.ru>
@dennwc dennwc requested a review from juanjux December 11, 2018 22:37
@juanjux
Copy link
Copy Markdown
Contributor

juanjux commented Dec 11, 2018

We locked the version because of an issue, but I'm going to guess that will be already fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants