*: support the statement of "rename database" #2
Merged
bb7133 merged 2 commits intobb7133:4.0-itaifrom Apr 29, 2020
Merged
Conversation
djshow832
reviewed
Apr 28, 2020
AilinKid
reviewed
Apr 28, 2020
| type RenameDatabaseStmt struct { | ||
| ddlNode | ||
|
|
||
| OldDB string |
There was a problem hiding this comment.
@zimulala If not do this, we need convert it to CIStr when use this field in TiDB, e.g.
model.NewCIstr(renameDatabaseStmt.OldDB).
If change to CIStr here, we can use it directly in TiDB.
Author
There was a problem hiding this comment.
I think it's OK. "create database" and "drop database" all use string.
LGTM |
Author
|
PTAL @djshow832 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support the statement of "rename database".
RENAME {DATABASE | SCHEMA} db_name TO new_db_name;The related MySQL docs.
What is changed and how it works?
Support the syntax of "rename database".
Check List
Tests
Code changes