Handle rust_library_group dependencies in more places #3617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b1a753 to
45ec85b
Compare
UebelAndre
approved these changes
Sep 16, 2025
Collaborator
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks! Could you also add a regression test that passes rust_library_group to deps, proc_macro_deps and cargo_build_script?
UebelAndre
requested changes
Sep 16, 2025
Collaborator
UebelAndre
left a comment
There was a problem hiding this comment.
Oops, meant to request the change. But the it does otherwise look like a good change 😅
cfa3372 to
1bc90c6
Compare
1bc90c6 to
29112e7
Compare
Contributor
Author
Good idea, done |
UebelAndre
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives downstream rules more flexibility in how deps are supplied to various attributes