Export CcInfo for staticlib & cdylib allowing rust outputs to be used in c++ rules#361
Merged
damienmg merged 1 commit intobazelbuild:masterfrom Jul 1, 2020
Merged
Conversation
127aa4f to
35a53d6
Compare
damienmg
approved these changes
Jun 30, 2020
Collaborator
damienmg
left a comment
There was a problem hiding this comment.
Thanks for this PR! I just have a bunch of comment on the TODOs the code itself is a great improvement.
35a53d6 to
7298c5f
Compare
damienmg
reviewed
Jun 30, 2020
…e used in c++ rules
7298c5f to
9eed519
Compare
Contributor
Author
|
Rebased to the latest and made more comment changes as per review |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its minor but since
CcInfonow exists we can statestaticlibto be a statlclib andcdylibto be the relevant.so