Skip to content

Add buildifier hook #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UebelAndre merged 1 commit into from
Aug 1, 2025
Merged

Add buildifier hook #3529

UebelAndre merged 1 commit into from
Aug 1, 2025

Conversation

@hofbi
Copy link
Contributor

@hofbi hofbi commented Jul 25, 2025

Replace the buildifier CI call with the pre-commit hook. Now developers can run exactly the same formatting and linting as we use in CI

UebelAndre
UebelAndre requested changes Jul 26, 2025
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think adding a pre-commit hook is fine but I don't think we should disable the CI check otherwise folks thinks could be missed by folks who didn't run the pre-commit hook. Can you re-enable that in this change?

@hofbi
Copy link
Contributor Author

hofbi commented Jul 26, 2025 •
edited
Loading

Thanks! I think adding a pre-commit hook is fine but I don't think we should disable the CI check otherwise folks thinks could be missed by folks who didn't run the pre-commit hook. Can you re-enable that in this change?

Buildifier is still running in CI as part of pre-commit. If you scroll down to the end of the CI job you can see the pre-commit run --all-files. This will make sure that all formatters we maintain in pre-commit are also executed in CI.

If you look at the CI logs of this branch, you can see that buildifier is still executed.

illicitonion
illicitonion approved these changes Jul 26, 2025
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@hofbi
Copy link
Contributor Author

hofbi commented Jul 28, 2025

@UebelAndre PTAL

@UebelAndre UebelAndre added this pull request to the merge queue Aug 1, 2025
Merged via the queue into bazelbuild:main with commit c7d8b15 Aug 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illicitonion illicitonion illicitonion approved these changes

@UebelAndre UebelAndre UebelAndre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hofbi @illicitonion @UebelAndre