Fix documentation for experimental_per_crate_rustc_flag.
#3380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting was introduced in [this commit](bazelbuild@6571cde), and from the context there ([docs](bazelbuild@6571cde#diff-2a806da393e47c07ffe67c78ace69eb488b4ac44b029a46d8237b8e2a05637be), [tests](bazelbuild@6571cde#diff-7cfe86db91ef77d2663a7f891492547fcae21fc081ae947532f031585eb86f1d)), it seems clear that the intent is that the flag should apply to non-exec configurations. When [this commit](bazelbuild@eb1fe7d#diff-d516c822cec75e56bb5c193fbd7c7dfd28d8f982224175324da28b61bf6a1fe3) later introduced the documentation being changed here, it seems that it inadvertently misunderstood the flag as applying _only_ to exec configurations, rather than _not_ to exec configurations.
UebelAndre
approved these changes
Apr 1, 2025
Collaborator
UebelAndre
left a comment
There was a problem hiding this comment.
Wow, what an unfortunate mistake. Thanks for fixing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting was introduced in this commit, and from the context there (docs, tests), it seems clear that the intent is that the flag should apply to non-exec configurations.
When this commit later introduced the documentation being changed here, it seems that it inadvertently misunderstood the flag as applying only to exec configurations, rather than not to exec configurations.