Change target to targets for license_policy_check#122
Merged
aiuto merged 1 commit intobazelbuild:mainfrom Oct 28, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
license_policy_checkis applied to a target that generates multiple files, the policy check fails. See below for an example error message.This seems to be due to
allow_single_file = Truein the description of the rule's attrtarget. This change removes the line, allowing a policy check to be applied to targets producing multiple files or a single file.This change was tested by applying
license_policy_checkto ajava_binarytarget (producing 2 files) and ajava_librarytarget (producing 1 file). Both policy checks ran successfully.Cloned from #71.
Fixes #71