Merged
Conversation
Closed
aiuto
approved these changes
Oct 19, 2023
Collaborator
aiuto
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
If you are inclined to help. We do have to get the checker_demo out of "tools" and into "examples". Then, along with that, get the "check_license()" rule out of rules and also into examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bazel build //examples/src:check_serverproduces emptyserver_licenses.txtandserver_report.txtfiles. This PR fixes this. Consider adding a test to avoid breakage.