Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Add support for select statement for k8s_objects.#342

Merged
k8s-ci-robot merged 9 commits intobazelbuild:masterfrom
ecosia:mp-k8s-objects-select
May 28, 2019
Merged

Add support for select statement for k8s_objects.#342
k8s-ci-robot merged 9 commits intobazelbuild:masterfrom
ecosia:mp-k8s-objects-select

Conversation

@Globegitter
Copy link
Copy Markdown

@Globegitter Globegitter commented May 21, 2019 •
edited
Loading

We are making use of --define flags to deploy targets into different environments. Right now we are making use of an alias to achieve this but it has limitations and adds code complexity that we would like to remove. Unfortunately macros can not manipulate select statements directly so I have to treat a dict as a special case. See bazelbuild/bazel#8419

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 21, 2019

Hi @Globegitter. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Globegitter Globegitter mentioned this pull request May 21, 2019
Open
@Globegitter Globegitter marked this pull request as ready for review May 21, 2019 13:11
@chrislovecnm
Copy link
Copy Markdown
Contributor

chrislovecnm commented May 22, 2019

/ok-to-test

Looks good, a rebase would be awesome :)

@Globegitter
Copy link
Copy Markdown
Author

Globegitter commented May 24, 2019

@chrislovecnm rebased :)

nlopezgi
nlopezgi reviewed May 24, 2019
View reviewed changes
@Globegitter
Copy link
Copy Markdown
Author

Globegitter commented May 28, 2019

Anything still blocking this to get this merged?

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Globegitter, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi
Copy link
Copy Markdown
Contributor

nlopezgi commented May 28, 2019

apilogies for the delay, thanks for the poke

@k8s-ci-robot k8s-ci-robot merged commit 16c002a into bazelbuild:master May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrislovecnm chrislovecnm Awaiting requested review from chrislovecnm

@smukherj1 smukherj1 Awaiting requested review from smukherj1

@alex1545 alex1545 Awaiting requested review from alex1545

@erain erain Awaiting requested review from erain

@xingao267 xingao267 Awaiting requested review from xingao267

1 more reviewer

@nlopezgi nlopezgi nlopezgi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nlopezgi nlopezgi

Labels

approved lgtm ok-to-test size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Globegitter @k8s-ci-robot @chrislovecnm @nlopezgi