Revert "Reference platformclasspath in @bazel_tools"#142
Merged
copybara-service[bot] merged 1 commit intobazelbuild:masterfrom Oct 17, 2023
Merged
Revert "Reference platformclasspath in @bazel_tools"#142copybara-service[bot] merged 1 commit intobazelbuild:masterfrom
platformclasspath in @bazel_tools"#142copybara-service[bot] merged 1 commit intobazelbuild:masterfrom
Conversation
This reverts commit 54e89da. Going through `@bazel_tools` to reference the bootstrap classpath is no longer needed with Bazel 7, which always uses toolchain macros that define the required bootstrap runtime toolchains. Since the original problem didn't arise with Bzlmod, where the Java toolchains have always come from rules_java rather than bazel_tools, this fixes bazelbuild/bazel#19837 for Bazel itself by allowing it to use the new bootstrap classpath rule while still being built with Bazel 6.4.0.
Contributor
Author
|
CC @hvadehra |
Contributor
Author
|
Is the next release planned to be |
This was referenced Oct 17, 2023
Member
Yes, there are also another breaking change in the next release. Is this change needed for Bazel 7? |
Contributor
Author
It is needed to fix bazelbuild/bazel#19837, which currently blocks bazelbuild/bazel#18262 and that would be great to get into Bazel 7. As an alternative, we could also cherry-pick bazelbuild/bazel@149cbce into 6.4.0, but I don't know whether that is 100% safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 54e89da.
Going through
@bazel_toolsto reference the bootstrap classpath is no longer needed with Bazel 7, which always uses toolchain macros that define the required bootstrap runtime toolchains.Since the original problem didn't arise with Bzlmod, where the Java toolchains have always come from rules_java rather than bazel_tools, this fixes bazelbuild/bazel#19837 for Bazel itself by allowing it to use the new bootstrap classpath rule while still being built with Bazel 6.4.0.